Open
Conversation
ISSOtm
added
bug
Rangi42
reviewed
Mar 9, 2026
Rangi42
requested changes
Mar 9, 2026
Comment on lines
+7
to
+9
| set(ONLY_FREE $<IF:$<BOOL:USE_NONFREE_TESTS>,,--only-free>) | ||
| set(ONLY_INTERNAL $<IF:$<BOOL:USE_EXTERNAL_TESTS>,,--only-internal>) | ||
| set(OS_NAME "$<IF:$<STREQUAL:${TESTS_OS_NAME},>,,--os;${TESTS_OS_NAME}>") |
Contributor
There was a problem hiding this comment.
That's some abstruse ternary syntax, but sure.
Contributor
There was a problem hiding this comment.
Actually, it might be breaking in FreeBSD?
Run command: bash -c 'cd /home/runner/work/rgbds/rgbds/test; ./fetch-test-deps.sh $<IF:$<BOOL:USE_NONFREE_TESTS>,,--only-free> $<IF:$<BOOL:USE_EXTERNAL_TESTS>,,--only-internal>'
bash: -c: line 1: syntax error near unexpected token `newline'
bash: -c: line 1: `cd /home/runner/work/rgbds/rgbds/test; ./fetch-test-deps.sh $<IF:$<BOOL:USE_NONFREE_TESTS>,,--only-free> $<IF:$<BOOL:USE_EXTERNAL_TESTS>,,--only-internal>'
Problem running command: bash -c 'cd /home/runner/work/rgbds/rgbds/test; ./fetch-test-deps.sh $<IF:$<BOOL:USE_NONFREE_TESTS>,,--only-free> $<IF:$<BOOL:USE_EXTERNAL_TESTS>,,--only-internal>'
Problem executing pre-test command(s).
Errors while running CTest
I'd be fine with using ordinary ifs here.
Member
Author
There was a problem hiding this comment.
I agree this ternary synax looks a little icky, but I was trying to avoid five lines of conditional logic per option here, for readability. Tradeoffs tradeoffs...
Comment on lines
+29
to
+35
| add_compile_options( | ||
| /MP # Build multiple files in parallel. | ||
| /wd5105 # MSVC's own standard library triggers warning C5105, "macro expansion producing 'defined' has undefined behavior". | ||
| /wd5030 # Warning C5030 is about unknown attributes (`[[gnu::ATTR]]`), none of ours being load-bearing. | ||
| /wd4996 # Warning C4996 is about using POSIX names, which we want to do for portability. | ||
| /Zc:preprocessor # Opt into the C++20-conformant preprocessor. | ||
| ) |
Contributor
There was a problem hiding this comment.
These are long enough that they could be header-style not inline-style (like the comment on -Wno-gnu-zero-variadic-macro-arguments below):
Suggested change
| add_compile_options( | |
| /MP # Build multiple files in parallel. | |
| /wd5105 # MSVC's own standard library triggers warning C5105, "macro expansion producing 'defined' has undefined behavior". | |
| /wd5030 # Warning C5030 is about unknown attributes (`[[gnu::ATTR]]`), none of ours being load-bearing. | |
| /wd4996 # Warning C4996 is about using POSIX names, which we want to do for portability. | |
| /Zc:preprocessor # Opt into the C++20-conformant preprocessor. | |
| ) | |
| add_compile_options( | |
| # Build multiple files in parallel | |
| /MP | |
| # MSVC's own standard library triggers warning C5105, | |
| # "macro expansion producing 'defined' has undefined behavior" | |
| /wd5105 | |
| # Warning C5030 is about unknown attributes (`[[gnu::ATTR]]`), | |
| # none of ours being load-bearing. | |
| /wd5030 | |
| # Warning C4996 is about using POSIX names, | |
| # which we want to do for portability. | |
| /wd4996 | |
| # Opt into the C++20-conformant preprocessor. | |
| /Zc:preprocessor | |
| ) |
Member
Author
There was a problem hiding this comment.
Since the CMakeLists is quite long, I was trying to keep it more compact. But if you think that this is nonetheless better, I'd be fine with you committing this.
ISSOtm
changed the title
ISSOtm
force-pushed
the
issotm/cmake-max
branch
3 times, most recently
from
ede1f65 to
31637e3
Compare
Also bump it to the version I just tested it with
This can help bring attention to the MSVC difference (no UBSan there)
Turns out the status messages use 3.17
We can use them now that the minimum version has been bumped
Also switch to heredoc syntax for ease of editing
ISSOtm
force-pushed
the
issotm/cmake-max
branch
from
31637e3 to
0c713db
Compare
Make the common files into an object library, which lets them be compiled only once (saving 41 build steps) This also lends itself well to removing the per-program loop, which simplifies the code somewhat.
No longer triggers now, so we can remove our workaround for their breakage.
ISSOtm
force-pushed
the
issotm/cmake-max
branch
from
0c713db to
32def3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bump it to the version I just tested it with